Allow dead_code on AlignedType#689
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Mar 26, 2024
Merged
Conversation
We use the `AlignedType` and take a pointer to its inner data, never access the data directly - this confuses clippy causing a "field is never used" warning. Shoosh the lint and add a code comment explaining why.
This was referenced Mar 26, 2024
apoelstra
approved these changes
Mar 26, 2024
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
873ad47343f3dba2fd9f7f9b9944a6214e656512 Allow dead_code on AlignedType (Tobin C. Harding)
Pull request description:
We use the `AlignedType` and take a pointer to its inner data, never access the data directly - this confuses clippy causing a "field is never used" warning.
Shoosh the lint and add a code comment explaining why.
ACKs for top commit:
apoelstra:
ACK 873ad47343f3dba2fd9f7f9b9944a6214e656512
Tree-SHA512: 2a383aed169edf247def5c291bc2d8177cc09412b82bb47bb514e0929ae89d689102e646dcbbffc6fd4caa1ce1430420a63c7ceb3428ad9b05230a93b7f14d16
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
873ad47343f3dba2fd9f7f9b9944a6214e656512 Allow dead_code on AlignedType (Tobin C. Harding)
Pull request description:
We use the `AlignedType` and take a pointer to its inner data, never access the data directly - this confuses clippy causing a "field is never used" warning.
Shoosh the lint and add a code comment explaining why.
ACKs for top commit:
apoelstra:
ACK 873ad47343f3dba2fd9f7f9b9944a6214e656512
Tree-SHA512: 2a383aed169edf247def5c291bc2d8177cc09412b82bb47bb514e0929ae89d689102e646dcbbffc6fd4caa1ce1430420a63c7ceb3428ad9b05230a93b7f14d16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the
AlignedTypeand take a pointer to its inner data, never access the data directly - this confuses clippy causing a "field is never used" warning.Shoosh the lint and add a code comment explaining why.